Skip to content

Fix #3782: Fix type parameter inference with scala.Singleton #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2018
Merged

Fix #3782: Fix type parameter inference with scala.Singleton #3783

merged 1 commit into from
Jan 15, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented Jan 9, 2018

The fix in ec53918 was incomplete: we
need to check if the upper bound is a subtype and not just a reference
to scala.Singleton

@smarter
Fix scala#3782: Fix type parameter inference with scala.Singleton
6a8c29a 
The fix in ec53918 was incomplete: we
need to check if the upper bound is a subtype and not just a reference
to scala.Singleton
@smarter smarter requested a review from odersky January 9, 2018 16:51
odersky
odersky approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good catch.

@smarter smarter merged commit 714e5bf into scala:master Jan 15, 2018
@allanrenucci allanrenucci deleted the fix-singleton-again branch January 16, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarter @odersky